[PATCH] D45916: Enable MachineOutliner by default under -Oz for AArch64

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 23 12:41:24 PDT 2018


efriedma added a comment.

The code in this patch looks fine.

In terms of the policy decision of actually turning it on by default, I'm mostly comfortable with it. Outlining has gotten a reasonable amount of testing, and I think the AArch64 hooks are correct.  One potential issue which I still need to look into is whether we need to disable outlining for fragments which use r16 and r17; it would be rare and difficult to reproduce, but the linker could theoretically insert a veneer that clobbers those registers in some cases.


https://reviews.llvm.org/D45916





More information about the llvm-commits mailing list