[PATCH] D47252: partitionSetParts from C to C++ interface.

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added inline comments.


================
Comment at: lib/Analysis/ScopInfo.cpp:1332
+                                                       unsigned Dim) {
 
+  for (unsigned u = 0, e = S.n_dim(); u < e; u++)
----------------
[Nit] Unnecessary additional newline


================
Comment at: lib/Analysis/ScopInfo.cpp:3035
+  auto Parts = partitionSetParts(HeaderBBDom, LoopDepth);
+
+  HeaderBBDom = Parts.second;
----------------
[Nit] Unnecessary additional newline


================
Comment at: lib/Analysis/ScopInfo.cpp:3042
   if (Affinator.hasNSWAddRecForLoop(L)) {
-    isl_set_free(Parts.first);
+    // isl_set_free(Parts.first);
     return true;
----------------
[Nit] Please remove commented code entirely.


================
Comment at: lib/Analysis/ScopInfo.cpp:3049
                    HeaderBB->getTerminator()->getDebugLoc(), AS_RESTRICTION);
+
   return true;
----------------
[Nit] Stray change


Repository:
  rPLO Polly

https://reviews.llvm.org/D47252