[PATCH] D45520: [PowerPC] add secure plt support for TLS symbols

[Hal Finkel via Phabricator via llvm-commits]

hfinkel added inline comments.


================
Comment at: lib/Target/PowerPC/PPCAsmPrinter.cpp:494
+      TlsRef = MCBinaryExpr::createAdd(TlsRef,
+                                       MCConstantExpr::create(32768, OutContext),
+                                       OutContext);
----------------
Please add a comment here explaining why we're adding 32768.


================
Comment at: lib/Target/PowerPC/PPCISelDAGToDAG.cpp:4021
+      // Attach global base pointer on GETtlsADDR32 node in order to
+      // generate secure plt code for TLS symbols
+      getGlobalBaseReg();
----------------
Period at the end of the comment.


Repository:
  rL LLVM

https://reviews.llvm.org/D45520