[PATCH] D46874: [MC] - Add .stack_size sections into groups and link them with .text

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: test/CodeGen/X86/stack-size-section.ll:16
 ; CHECK-NEXT: .Lfunc_begin1:
 ; CHECK: .section .stack_sizes,"", at progbits
 ; CHECK-NEXT: .quad .Lfunc_begin1
----------------
Should we still have SHF_LINK_ORDER in these cases? If we GC (or otherwise discard) the text section here, we'll still keep the stack_sizes section, which I don't think we want to do.

I know -gc-sections without -function-sections is rare, but it is legal, and LLD does potentially strip some sections (imagine an object file with only one or two unused functions in, for example).


https://reviews.llvm.org/D46874