[PATCH] D47126: [RISCV] Add missing fixup_riscv_call in MCFixupKindInfo table
Alex Bradbury via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 23 05:36:51 PDT 2018
asb added inline comments.
================
Comment at: test/CodeGen/RISCV/function-call.ll:3
+; RUN: | llvm-readobj -r | FileCheck -check-prefix=RELOC %s
+
+define i32 @foo(i32 %a, i32 %b) nounwind {
----------------
I think a comment explaining the purpose of the test would be useful. Presumably it's something like "Check that not attempt is made to resolve a call fixups and a relocation is always emitted". Of course this would be unnecessary if we could add support for correctly resolving call fixups!
Repository:
rL LLVM
https://reviews.llvm.org/D47126
More information about the llvm-commits
mailing list