[PATCH] D47246: [llvm-mca] Introduce the ExecuteStage (was originally the Scheduler class).

Andrea Di Biagio via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 23 03:05:21 PDT 2018


andreadb added a comment.

What I am trying to say is that the stage should only be responsible for the process (i.e. orchestrating the execution).
The logic that lives in `Scheduler::cycleEvent()` is essentially where the "process" logic is implemented. That logic (plus the event notification logic) should be moved to the stage class. The rest of the logic should still be part of the Scheduler class. Basically, the stage is only where we control the execution. It helps decoupling the actual feature from the process (i.e. how we use the feature/interact with the hardware components).


https://reviews.llvm.org/D47246





More information about the llvm-commits mailing list