[PATCH] D47153: [Support] Avoid normalization in sys::getDefaultTargetTriple

[Dan Liew via Phabricator via llvm-commits]

delcypher added a comment.

In https://reviews.llvm.org/D47153#1107469, @phosek wrote:

> In https://reviews.llvm.org/D47153#1106780, @delcypher wrote:
>
> > I'm not familiar with this code but if I'm reading the patch correctly, then the commit message omits the fact that it changes he windows target triple from having a `win32` suffix to `windows-msvc` suffix. I'm not sure what the implications are here but the fact you've done this is probably worth mentioning in the commit message.
>
>
> Done. I've also tested this change on Windows and this seems to be passing now so should be ready for re-land.


Thanks. This code really isn't my area though so you should wait for a LGTM from one of your reviewers.



================
Comment at: llvm/utils/lit/lit/llvm/config.py:253
+        if os == 'windows':
             # If the OS is win32, we're done.
             return triple
----------------
This comment probably needs updating. s/win32/windows/


Repository:
  rL LLVM

https://reviews.llvm.org/D47153