[PATCH] D46809: [GlobalISel] NFCI, Getting GlobalISel ~5% faster

[Roman Tereshin via Phabricator via llvm-commits]

rtereshin added a comment.

In https://reviews.llvm.org/D46809#1105122, @qcolombet wrote:

> Nice finding Roman.
>
> I second Jessica, we should have more comprehensive testing to make sure we are not optimizing for one benchmark.
>
> Otherwise LGTM.


Thanks!

Here we go:

| Name                                          | Prev    | Current | %      | Δ       | MAD    | N  |
| --------------------------------------------- | ------- | ------- | ------ | ------- | ------ | -- |
|                                               |         |         |        |         |        |    |
| CTMark/7zip/7zip-benchmark                    | 15.3903 | 15.2923 | -0.64% | -0.0980 | 0.0047 | 30 |
| CTMark/7zip/7zip-benchmark-link               | 0.0750  | 0.0745  | -0.67% | -0.0005 | 0.0024 | 30 |
| CTMark/Bullet/bullet                          | 12.0264 | 11.9626 | -0.53% | -0.0638 | 0.0081 | 30 |
| CTMark/Bullet/bullet-link                     | 0.0666  | 0.0662  | -0.60% | -0.0004 | 0.0005 | 30 |
| CTMark/ClamAV/clamscan                        | 3.2851  | 3.2562  | -0.88% | -0.0289 | 0.0034 | 30 |
| CTMark/ClamAV/clamscan-link                   | 0.0275  | 0.0275  | 0.00%  | 0.0000  | 0.0003 | 30 |
| CTMark/SPASS/SPASS                            | 2.6950  | 2.6815  | -0.50% | -0.0135 | 0.0029 | 30 |
| CTMark/SPASS/SPASS-link                       | 0.0303  | 0.0303  | 0.00%  | 0.0000  | 0.0002 | 30 |
| CTMark/consumer-typeset/consumer-typeset      | 2.5922  | 2.5650  | -1.05% | -0.0272 | 0.0047 | 30 |
| CTMark/consumer-typeset/consumer-typeset-link | 0.0252  | 0.0252  | 0.00%  | 0.0000  | 0.0002 | 30 |
| CTMark/kimwitu++/kc                           | 5.8438  | 5.8180  | -0.44% | -0.0258 | 0.0075 | 30 |
| CTMark/kimwitu++/kc-link                      | 0.0652  | 0.0649  | -0.46% | -0.0003 | 0.0003 | 30 |
| CTMark/lencod/lencod                          | 2.4405  | 2.4152  | -1.04% | -0.0253 | 0.0028 | 30 |
| CTMark/lencod/lencod-link                     | 0.0264  | 0.0264  | 0.00%  | 0.0000  | 0.0001 | 30 |
| CTMark/mafft/pairlocalalign                   | 1.2078  | 1.1960  | -0.98% | -0.0118 | 0.0027 | 30 |
| CTMark/mafft/pairlocalalign-link              | 0.0189  | 0.0189  | 0.00%  | 0.0000  | 0.0001 | 30 |
| CTMark/sqlite3/sqlite3                        | 0.6303  | 0.6200  | -1.63% | -0.0103 | 0.0026 | 30 |
| CTMark/sqlite3/sqlite3-link                   | 0.0194  | 0.0193  | -0.52% | -0.0001 | 0.0000 | 30 |
| CTMark/tramp3d-v4/tramp3d-v4                  | 3.6254  | 3.5962  | -0.81% | -0.0292 | 0.0113 | 30 |
| CTMark/tramp3d-v4/tramp3d-v4-link             | 0.1176  | 0.1173  | -0.26% | -0.0003 | 0.0004 | 30 |
|



- Aggregation Function is Minimum
- **Prev** is r333057 (fb0360d185d35, Wed May 23 03:01:45 2018), MatchTable second level grouping, perf patch 5 <https://reviews.llvm.org/rL333053> has been recently applied.
- **Current** is the same + this patch.

Both are LLVM + Clang Release builds, assertions off, targets enabled are x86 and AArch64.

`lnt` is ran the following way:

  lnt runtest test-suite --sandbox tmp --cc ./llvm/build/obj/bin/clang \
    --cxx ./llvm/build/obj/bin/clang++ --use-cmake /usr/local/bin/cmake \
    --use-lit ./llvm/build/obj/bin/llvm-lit --test-suite $SRC/llvm-test-suite \
    --cflags '-O0' --cxxflags '-O0' --only-compile --build-threads 1 \
    --cmake-define TEST_SUITE_SUBDIRS=CTMark \
    --cmake-cache ./llvm-test-suite/cmake/caches/target-arm64-iphoneos.cmake \
    --benchmarking-only --compile-multisample 30 --succinct-compile-output

The hardware is iMac (SSD) running macOS.


Repository:
  rL LLVM

https://reviews.llvm.org/D46809