[PATCH] D47246: [llvm-mca] Introduce the ExecuteStage (was originally the Scheduler class).
Clement Courbet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 22 23:14:49 PDT 2018
courbet added inline comments.
================
Comment at: tools/llvm-mca/Backend.cpp:48
+ // notify of HW stalls.
+ if (!Dispatch->canDispatch(IR) || !Execute->canBeDispatched(IR))
break;
----------------
How do you intend to make this independent of the actual type of the Stages in the long term (when we have a vector<std::unique_ptr<Stage>> instead of Dispatch and Execute) ?
Would it make sense to use Stage::isReady() ?
https://reviews.llvm.org/D47246
More information about the llvm-commits
mailing list