[PATCH] D47214: [InstCombine] Replace bcmp/bcopy with memcmp/memmove

[Sanjoy Das via Phabricator via llvm-commits]

sanjoy added a comment.

In https://reviews.llvm.org/D47214#1108647, @xbolva00 wrote:

> I have no benchmarks. But changing them to mem-functions allows us to apply another set of transformations in "optimizeMemcmp/Memmove".


I see.  Are those secondary transformations important for some workload?

> Anyway, If you say no, no problem. I will close this patch.

To be clear, I don't want to discourage you from contributing to LLVM.  It is just that developer time (your time, reviewer time etc.) is expensive and we should be spending that towards the kinds of optimizations that matter, not towards implementing every possible transform under the sun.


Repository:
  rL LLVM

https://reviews.llvm.org/D47214