[PATCH] D47179: [LLVM-C] Add Bindings For Named Metadata

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 22 13:01:54 PDT 2018


dexonsmith added a comment.

In https://reviews.llvm.org/D47179#1107993, @aprantl wrote:

> Adding Duncan to the review list who (presumably) added the TODO and may have some thoughts on this.


Making `NamedMDNode` inherit from `Metadata` will allow `MDNode` to reference `NamedMDNode`.

- What's the use case for this?
- What complexity does it add to the IR?  (Especially, during serialization and LTO...)

Perhaps this is worth doing, but we need a compelling reason.  In retrospect, I'm not sure I had sufficient motiviation when I added the TODO.


Repository:
  rL LLVM

https://reviews.llvm.org/D47179





More information about the llvm-commits mailing list