[PATCH] D46267: [test-suite] Enable MicroBenchmarks by default

Brian Homerding via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 22 12:56:12 PDT 2018


homerdin added a comment.

The cmake system in the benchmark library uses cmake's `try_run` if `CMAKE_CROSSCOMPILING` is not set.  It looks like this is what was causing the failures (trying to run something it cannot).  The documentation for cross-compiling clang/llvm using clang/llvm lists `-DCMAKE_CROSSCOMPILING=True` as a needed cmake option.  I'm not sure if we would want the same for the test suite.  Ideally we would automatically set the variable when cross compiling.  I have not been able to reproduce the issue so I'm not certain if this is the cause.  Is anyone familiar with cmake and cross compilation?

  CMake Error at MicroBenchmarks/libs/benchmark-1.3.0/CMakeLists.txt:181 (message):
    Failed to determine the source files for the regular expression backend


Repository:
  rL LLVM

https://reviews.llvm.org/D46267





More information about the llvm-commits mailing list