[PATCH] D46709: [Dominators] Add PDT constructor from Function

[Jakub Kuderski via Phabricator via llvm-commits]

kuhar added a comment.

Looks almost ready -- I found only a couple of cosmetic issues. Once they are fix I can commit it for you.



================
Comment at: lib/Transforms/IPO/SampleProfile.cpp:1369
 
-  PDT.reset(new PostDomTreeBase<BasicBlock>());
+  PDT.reset(new PostDominatorTree);
   PDT->recalculate(F);
----------------
I think we can construct it directly here, like:
`new PostDominatorTree(F))`


================
Comment at: unittests/IR/DominatorTreeTest.cpp:29
     Module &M, StringRef FuncName,
-    function_ref<void(Function &F, DominatorTree *DT, PostDomTree *PDT)> Test) {
+    function_ref<void(Function &F, DominatorTree *DT, PostDominatorTree *PDT)> Test) {
   auto *F = M.getFunction(FuncName);
----------------
This seems to exceed the 80-character line limit. Can you format you patch with clang-format-diff.py?


https://reviews.llvm.org/D46709