[PATCH] D46967: Vector constrained FP intrinsics

[Cameron McInally via Phabricator via llvm-commits]

cameron.mcinally added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/LegalizeVectorOps.cpp:312
+    // ISD::STRICT_FSQRT.
+    Node = DAG.mutateStrictFPToFP(Node);
+    QueryType = Node->getValueType(0);
----------------
andrew.w.kaylor wrote:
> Do you actually want to mutate the node at this point?
> 
> There's a function, getStrictFPOpcodeAction() that does something very close to what you are doing here except without mutating the node. Would moving that to an accessible location do what you need?
Ah, I see the problem now. The splitting and expanding code needs to be taught how to handle the chain on constrained operations. I was inadvertently trying to mutate away the chain. This will probably take a while to sort out...

Thanks, Andrew.


Repository:
  rL LLVM

https://reviews.llvm.org/D46967