[PATCH] D47189: [llvm-exegesis] Analysis output uses HTML.
Clement Courbet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 22 05:46:39 PDT 2018
courbet marked an inline comment as done.
courbet added a comment.
In https://reviews.llvm.org/D47189#1107755, @gchatelet wrote:
> It might be worth splitting this file if it becomes too big.
I think 300 lines is still OK :D
================
Comment at: tools/llvm-exegesis/lib/Clustering.cpp:172
+operator<(const ClusterId &Other) const {
+ if (isValid()) {
+ if (Other.isValid()) {
----------------
gchatelet wrote:
> Can we try to leverage std::tie here?
> ```
> const bool IsValid = isValid();
> const bool OtherIsValid = Other.isValid();
> return std::tie(IsValid, Id) < std::tie(OtherIsValid, Other.Id);
>
> ```
I've made the ordering simpler.
Repository:
rL LLVM
https://reviews.llvm.org/D47189
More information about the llvm-commits
mailing list