[PATCH] D47189: [llvm-exegesis] Analysis output uses HTML.
Guillaume Chatelet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 22 05:34:31 PDT 2018
gchatelet requested changes to this revision.
gchatelet added a comment.
This revision now requires changes to proceed.
It might be worth splitting this file if it becomes too big.
================
Comment at: tools/llvm-exegesis/lib/Clustering.cpp:172
+operator<(const ClusterId &Other) const {
+ if (isValid()) {
+ if (Other.isValid()) {
----------------
Can we try to leverage std::tie here?
```
const bool IsValid = isValid();
const bool OtherIsValid = Other.isValid();
return std::tie(IsValid, Id) < std::tie(OtherIsValid, Other.Id);
```
Repository:
rL LLVM
https://reviews.llvm.org/D47189
More information about the llvm-commits
mailing list