[PATCH] D47158: [DWARFv5] Put DWO ID in its place

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.h:227
+    return DwarfUnit::getHeaderSize() +
+           (DD->getDwarfVersion() >= 5 && DD->useSplitDwarf() ? sizeof(uint64_t)
+                                                              : 0); // DWO Id
----------------
Nit: This looks a little awkward. I probably would've moved the ternary operator into a separate variable and used that in the return `DwarfUnit::getHeaderSize() + DwoIDSize;`


Repository:
  rL LLVM

https://reviews.llvm.org/D47158