[PATCH] D47189: [llvm-exegesis] Analysis output uses HTML.

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: tools/llvm-exegesis/lib/Analysis.cpp:28
+template <>
+void writeEscaped<kEscapeCsv>(llvm::raw_ostream &OS, const std::string &S) {
   if (std::find(S.begin(), S.end(), kCsvSep) == S.end()) {
----------------
This should take `StringRef`, not `std::string`


================
Comment at: tools/llvm-exegesis/lib/Analysis.cpp:45
+template <>
+void writeEscaped<kEscapeHtml>(llvm::raw_ostream &OS, const std::string &S) {
+  for (const char C : S) {
----------------
This should take `StringRef`, not `std::string`


Repository:
  rL LLVM

https://reviews.llvm.org/D47189