[PATCH] D47052: [llvm-objcopy] Fix the behavior of --strip-* and --keep-symbol

Alexander Shaposhnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 22 01:51:22 PDT 2018


alexshap added inline comments.


================
Comment at: tools/llvm-objcopy/llvm-objcopy.cpp:386
+  if (!Config.SymbolsToKeep.empty() && !Obj.SymbolTable->empty()) {
+    RemovePred = [&Obj, Config, RemovePred](const SectionBase &Sec) {
+      if (&Sec == Obj.SymbolTable || &Sec == Obj.SymbolTable->getStrTab())
----------------
jhenderson wrote:
> I don't think you need Config in the capture list?
you are right, Config should not be captured here.


Repository:
  rL LLVM

https://reviews.llvm.org/D47052





More information about the llvm-commits mailing list