[PATCH] D26556: [InstCombine] don't widen most selects by hoisting an extend

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 21 17:23:00 PDT 2018


spatel abandoned this revision.
spatel added a comment.

In https://reviews.llvm.org/D26556#620417, @efriedma wrote:

> If we could pattern-match our way out, it might be okay... but I don't think that's realistic in more complicated cases.  The sign-extend could be pushed forward through another operation or land in a different basic block.  I think it makes more sense to just try to make selects use the "right" width for the target (the width of the compare operands for most targets).


Sorry for the 18 month delay. Let's do that. :)
https://reviews.llvm.org/D47163

Abandoning.


https://reviews.llvm.org/D26556





More information about the llvm-commits mailing list