[PATCH] D47100: [CMake] Support libc++ as Clang default stdlib in compiler-rt

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 21 16:37:58 PDT 2018


vitalybuka added inline comments.


================
Comment at: compiler-rt/CMakeLists.txt:143
     set(SANITIZER_CXX_ABI_SYSTEM 1)
+  elseif (FUCHSIA)
+    set(SANITIZER_CXX_ABI_LIBNAME "libc++")
----------------
phosek wrote:
> vitalybuka wrote:
> > Is it possible to split the patch in parts and submit independently with some delay for easier debugging?
> Yes, totally. Do you have any preference? I could split the change to `test_target_arch` as one patch, change to options as a second one and change to `llvm/runtimes` as a third one?
sgtm


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D47100





More information about the llvm-commits mailing list