[PATCH] D47052: [llvm-objcopy] Fix the behavior of --strip-* and --keep-symbol

Jake Ehrlich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 21 15:17:13 PDT 2018


jakehehrlich added a comment.

In https://reviews.llvm.org/D47052#1106213, @jhenderson wrote:

> In https://reviews.llvm.org/D47052#1106208, @alexshap wrote:
>
> > so basically we can implement this option without trying to repeat binutils behavior,
> >  what would you say to this ? if so I can update the patch (and actually the code will be simpler)
>
>
> I'm of the opinion that if the GNU behaviour doesn't make sense, we shouldn't follow it blindly, so I'd be happy in a divergence here, but I'm not a regular GNU tools user, so it might be wise to get @jakehehrlich's thoughts on this before proceeding.


I agree. This dosn't make sense to me. We should only keep the explicitly kept symbol and anything it relays on.


Repository:
  rL LLVM

https://reviews.llvm.org/D47052





More information about the llvm-commits mailing list