[PATCH] D46896: [llvm-objcopy] Add --strip-unneeded option
Jake Ehrlich via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 21 15:15:08 PDT 2018
jakehehrlich added a comment.
One little thing and this LGTM
I think this pointed out some additional refactoring that's going to be needed though and I'm already behind on previously agreed on refactors :(
================
Comment at: tools/llvm-objcopy/Object.h:465
explicit GroupSection(ArrayRef<uint8_t> Data) : Contents(Data) {}
+ ~GroupSection() { --Sym->ReferenceCount; }
----------------
Please add nullptr check
Repository:
rL LLVM
https://reviews.llvm.org/D46896
More information about the llvm-commits
mailing list