[PATCH] D47158: [DWARFv5] Put DWO ID in its place
Adrian Prantl via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 21 14:12:33 PDT 2018
aprantl added a comment.
Seems reasonable to me.
================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFUnit.h:64
uint32_t TypeOffset = 0;
// Unit type as parsed, or derived from the section kind.
----------------
This is probably a silly micro-optimization, but for better packing we could move the DWOId here (assuming that it is 9 bytes large on a 64-bit architecture). Alternatively: is `0` a valid DWOId?
================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.h:86
+ // DWO ID for correlating skeleton and split units.
+ uint64_t DWOId = 0;
----------------
///
================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFContext.cpp:572
+ else
+ continue; // No DWO ID?
+ }
----------------
```
// No DWO ID?
continue;
```
Repository:
rL LLVM
https://reviews.llvm.org/D47158
More information about the llvm-commits
mailing list