[PATCH] D47143: [NewGVN] Do not treat LoadExpressions with differing nonnull as equal.

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

@fhahn It's probably not feasible to remove metadata or explicitly pass merged metadata as the relevant metadata may be somewhere further up the chain. E.g. we might not be looking at ICmp(Load, null) but at something like ICmp(BitCast(GEP(Load)), null), which will probably be subject to the same issues, as these checks are recursive.

Having the option to ignore metadata (or maybe have a lambda that determines whether metadata can be used, e.g. based on common metadata in all members of the congruence, or because of a dominating leader) sounds like a more robust solution.


https://reviews.llvm.org/D47143