[PATCH] D47156: [DAGCombiner] isAllOnesConstantOrAllOnesSplatConstant(): look through bitcasts

[Sanjay Patel via Phabricator via llvm-commits]

spatel added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:916
 static bool isAllOnesConstantOrAllOnesSplatConstant(SDValue N) {
+  while (N.getOpcode() == ISD::BITCAST)
+    N = N->getOperand(0);
----------------
Use peekThroughBitcast()


Should we do the same for isOneConstantOrOneSplatConstant and isNullConstantOrNullSplatConstant?


Repository:
  rL LLVM

https://reviews.llvm.org/D47156