[llvm] r332880 - Remove CMake workaround for LLD PR24476 which is no longer needed

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Mon May 21 13:14:46 PDT 2018


Author: rnk
Date: Mon May 21 13:14:46 2018
New Revision: 332880

URL: http://llvm.org/viewvc/llvm-project?rev=332880&view=rev
Log:
Remove CMake workaround for LLD PR24476 which is no longer needed

Modified:
    llvm/trunk/cmake/modules/HandleLLVMOptions.cmake

Modified: llvm/trunk/cmake/modules/HandleLLVMOptions.cmake
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/HandleLLVMOptions.cmake?rev=332880&r1=332879&r2=332880&view=diff
==============================================================================
--- llvm/trunk/cmake/modules/HandleLLVMOptions.cmake (original)
+++ llvm/trunk/cmake/modules/HandleLLVMOptions.cmake Mon May 21 13:14:46 2018
@@ -48,14 +48,6 @@ elseif(LLVM_PARALLEL_LINK_JOBS)
   message(WARNING "Job pooling is only available with Ninja generators.")
 endif()
 
-if (LINKER_IS_LLD_LINK)
-  # Pass /MANIFEST:NO so that CMake doesn't run mt.exe on our binaries.  Adding
-  # manifests with mt.exe breaks LLD's symbol tables and takes as much time as
-  # the link. See PR24476.
-  append("/MANIFEST:NO"
-    CMAKE_EXE_LINKER_FLAGS CMAKE_MODULE_LINKER_FLAGS CMAKE_SHARED_LINKER_FLAGS)
-endif()
-
 if( LLVM_ENABLE_ASSERTIONS )
   # MSVC doesn't like _DEBUG on release builds. See PR 4379.
   if( NOT MSVC )




More information about the llvm-commits mailing list