[PATCH] D47149: [SCCP] Mark DominatorTreeAnalysis as preserved.

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 21 13:09:48 PDT 2018


davide added a comment.

In https://reviews.llvm.org/D47149#1106684, @fhahn wrote:

> Right, IPSCCP does use changeToUnreachable, but it can be told to update the DT. The thing that confused me is that we use removeAllNonTerminatorInstruction... in runSCCP with a comment that we should not change the CFG. Is there a reason we use changeToUnreachable in IPSCCP but removeAllNonTerminatorInstruction... in SCCP?


I don't think there's a good one, FWIW.


https://reviews.llvm.org/D47149





More information about the llvm-commits mailing list