[PATCH] D47152: [DebugInfo] Use absolute addresses in location lists

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere marked 2 inline comments as done.
JDevlieghere added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDie.cpp:111-115
+        uint64_t BaseAddr = 0;
+        if (Optional<BaseAddress> BA = U->getBaseAddress())
+          BaseAddr = BA->Address;
+        LL->dump(OS, Ctx.isLittleEndian(), Obj.getAddressSize(), MRI, BaseAddr,
+                 Indent);
----------------
dblaikie wrote:
> Might be able to replace "BaseAddr" with "U->getBaseAddress().getValueOr(0)" ?
I think that wouldn't work here because the Optional wraps the struct rather than the unsigned?


Repository:
  rL LLVM

https://reviews.llvm.org/D47152