[PATCH] D47143: [NewGVN] Do not treat LoadExpressions with differing nonnull as equal.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

In https://reviews.llvm.org/D47143#1106573, @dberlin wrote:

> Hey Florian, 
>  Thanks for looking at this:
>  IMHO, We should be storing and hashing/comparing the relevant info in the loadexpression (IE store a bit that it's nonnull)
>  I really do not want to end up with complex business logic in the equals function, that's a thing the callers should be worrying about.


Will do thanks. As @nikic mentioned we have to account for more than nonnull, which I'll do once nonnull is dealt with properly.


https://reviews.llvm.org/D47143