[PATCH] D47143: [NewGVN] Do not treat LoadExpressions with differing nonnull as equal.

Daniel Berlin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 21 09:09:20 PDT 2018


dberlin added a comment.

Hey Florian, 
Thanks for looking at this:
IMHO, We should be storing and hashing/comparing the relevant info in the loadexpression (IE store a bit that it's nonnull)
I really do not want to end up with complex business logic in the equals function, that's a thing the callers should be worrying about.


https://reviews.llvm.org/D47143





More information about the llvm-commits mailing list