[PATCH] D46893: [CVP] Require DomTree for new Pass Manager

[Dave Green via Phabricator via llvm-commits]

dmgreen closed this revision.
dmgreen added a comment.

https://reviews.llvm.org/rL332836

I also forgot to mention I took a quick look and it appears that getBestSimplifyQuery is only used in two places, here in CVP and LoopRotate.

As LoopRotate is a loop pass, it will always have access to all the analyses via LoopStandardAnalysisResults.

I'm pretty sure that TLI, and AC are all so cheap we could just always require them in getBestSimplifyQuery (at least without paying any cost in getBestSimplifyQuery, I guess they could still cause more cost in InstructionSimplify). That would still leave what to do about DT.


https://reviews.llvm.org/D46893