[PATCH] D47059: [InstCombine] Calloc-ed strings optimizations

[Benjamin Kramer via Phabricator via llvm-commits]

bkramer added inline comments.


================
Comment at: lib/Transforms/Utils/SimplifyLibCalls.cpp:215
+    B.CreateMemCpy(Dst, 1, Src, 1,
+                   ConstantInt::get(DL.getIntPtrType(CI->getContext()), Len));
+    return Dst;
----------------
What if strlen(Src) < Len?


================
Comment at: lib/Transforms/Utils/SimplifyLibCalls.cpp:207
 
+  // strncat("\0", str, len) -> strncpy("\0", str, len))
+  uint64_t DstLen = GetStringLength(Dst, TLI);
----------------
Is this correct? strncpy fills the rest of the string with null bytes, strncat does not.


https://reviews.llvm.org/D47059