[PATCH] D47113: [CVP] Teach CorrelatedValuePropagation to reduce the width of lshr instruction.

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In https://reviews.llvm.org/D47113#1106126, @bixia wrote:

> Why the transformation here doesn't need similar check?


I would like that design criteria to be documented somewhere, too.

In https://reviews.llvm.org/D47113#1106126, @bixia wrote:

> Is it safe to remove such a check in InstCombiner::visitLShr?


No:

In https://reviews.llvm.org/D46760#1105919, @spatel wrote:

> Re: instcombine - if some transform is increasing instruction count by not checking for uses, that's a bug. I think we established that conclusively in https://reviews.llvm.org/D44266.



Repository:
  rL LLVM

https://reviews.llvm.org/D47113