[PATCH] D47059: [InstCombine] Calloc-ed strings optimizations

Dávid Bolvanský via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 21 02:56:28 PDT 2018


xbolva00 added inline comments.


================
Comment at: include/llvm/Analysis/ValueTracking.h:277
   /// pointer, return 'len+1'.  If we can't, return 0.
-  uint64_t GetStringLength(const Value *V, unsigned CharSize = 8);
+  uint64_t GetStringLength(Value *V, const TargetLibraryInfo *TLI, unsigned CharSize = 8);
 
----------------
Or should I leave const here and then const_cast for dyn_cast in isStringFromCalloc?


https://reviews.llvm.org/D47059





More information about the llvm-commits mailing list