[PATCH] D46896: [llvm-objcopy] Add --strip-unneeded option

[Paul Semel via Phabricator via llvm-commits]

paulsemel added a comment.

In https://reviews.llvm.org/D46896#1106180, @jhenderson wrote:

> Could you add a test for --strip-unneeded and group sections, please.
>
> Thinking more about testing, what's the behaviour of --strip-unneeded + --remove-section <some relocation section> and are we happy with it?




In https://reviews.llvm.org/D46896#1106180, @jhenderson wrote:

> Could you add a test for --strip-unneeded and group sections, please.


Sure.

> Thinking more about testing, what's the behaviour of --strip-unneeded + --remove-section <some relocation section> and are we happy with it?

For the moment, as the section removal occurs before, the symbol will be deleted, as the relocation referencing it doesn't exist anymore. In `objcopy`, I believe the section removal occurs after, as the symbol is not deleted.
Anyway, if this PR (https://reviews.llvm.org/D47052) is accepted, we will match `objcopy` behavior (I actually prefer the current way).


Repository:
  rL LLVM

https://reviews.llvm.org/D46896