[PATCH] D46998: [XRay][compiler-rt] Limit reliance on C++ ABI features

[Eric Christopher via Phabricator via llvm-commits]

echristo added a comment.

One general inline comment. Otherwise, yes, any decoupling you can do from the C++ standard library is goodness.



================
Comment at: compiler-rt/lib/xray/xray_basic_logging.cc:165
   uint8_t CPU = 0;
-  uint64_t TSC = ReadTSC(CPU);
+  u64 TSC = ReadTSC(CPU);
 
----------------
Mild preference to avoid u64 and still use uint64_t here.


https://reviews.llvm.org/D46998