[PATCH] D47032: Support: Simplify endian stream interface. NFCI.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 18 12:47:08 PDT 2018


pcc added a comment.

In https://reviews.llvm.org/D47032#1104861, @ruiu wrote:

> LGTM
>
> If I were to design this from scratch, I'd perhaps define two classes, LEWriter and BEWriter, instead of giving the endianness as an argument. But that's an off-topic.


Maybe, but it will need to be an argument in a few other places, such as ELFObjectWriter (see https://reviews.llvm.org/D47040). Though maybe we could somehow template it on ELFT as we do in lld... but that's another separate discussion.


https://reviews.llvm.org/D47032





More information about the llvm-commits mailing list