[PATCH] D47051: MC: Introduce an ELF dwo object writer and teach llvm-mc about it.

Eric Christopher via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 20 21:40:57 PDT 2018


echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.

And it even comes with testcases. :)

LGTM.

-eric



================
Comment at: llvm/lib/MC/ELFObjectWriter.cpp:165
   ELFWriter(ELFObjectWriter &OWriter, raw_pwrite_stream &OS,
-            bool IsLittleEndian)
+            bool IsLittleEndian, DwoMode Mode)
       : OWriter(OWriter),
----------------
It feels a little awkward to special case this for dwo files rather than just be a general object emitter. That said, generalization should be possible in the future.


https://reviews.llvm.org/D47051





More information about the llvm-commits mailing list