[PATCH] D47088: Fix aliasing of launder.invariant.group

[Hal Finkel via Phabricator via llvm-commits]

hfinkel added inline comments.


================
Comment at: llvm/lib/Analysis/BasicAliasAnalysis.cpp:435
+        // Note: getArgumentAliasingToReturnedPointer keeps CaptureTracking in
+        // sync, which is needed for correctness.
+        if (auto *RP = getArgumentAliasingToReturnedPointer(CS)) {
----------------
Prazek wrote:
> hfinkel wrote:
> > Please explain here *how* this keeps this in sync. There's no obvious use of CaptureTracking here.
> I updated the comment, but I have a new idea how to make it better. I will refactor the list of intrinsic to some other function, to make it always in sync.
That's good, but doesn't explain why keeping these in sync is necessary for correctness. To put it another way, please explain what does wrong if these are not in sync.


Repository:
  rL LLVM

https://reviews.llvm.org/D47088