[PATCH] D46326: ThinLTO+CFI: short-circuit direct calls to jump table entries
Peter Collingbourne via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat May 19 14:40:40 PDT 2018
pcc added a comment.
In https://reviews.llvm.org/D46326#1105694, @vlad.tsyrklevich wrote:
> Based on a quick look at a couple of stack traces it looks like some direct
> calls now call symbols that are no longer overriden by their replacements
> in chromium, e.g. calls to realloc() from a DSO previously resolved to the
> tcmalloc implementation in chromium instead of realloc.cfi(), the locally
> linked tcmalloc implementation in that library.
I imagine that we will need to limit this optimization to dso_local functions.
Repository:
rL LLVM
https://reviews.llvm.org/D46326
More information about the llvm-commits
mailing list