[PATCH] D43962: [GlobalISel][utils] Adding the init version of Instruction Select Testgen

Roman Tereshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 18 20:55:38 PDT 2018


rtereshin updated this revision to Diff 147646.
rtereshin added a comment.

I have:

1. Fixed IR-building code that failed to update def-use chains properly until very end of the test generation, rendering GIM_CheckSameOperands fragile and dependent on which operand was already defined / checked explicitly and which one is not
2. Started sorting machine instructions inserted in topological order explicitly (rather than implicity relying on GIM_RecordInsn's opcodes), thus a) reducing the size of the diffs in case of changes b) making GIM_CheckSameOperands less fragile (it could have created uses not dominated by defs previously)
3. Stabilized resulting vreg numbers to reduce the diffs in case of changes


Repository:
  rL LLVM

https://reviews.llvm.org/D43962

Files:
  include/llvm/CodeGen/GlobalISel/InstructionSelectTestgen.h
  include/llvm/CodeGen/GlobalISel/InstructionSelector.h
  include/llvm/CodeGen/GlobalISel/InstructionSelectorImpl.h
  include/llvm/CodeGen/GlobalISel/InstructionSelectorTestgen.h
  include/llvm/InitializePasses.h
  lib/CodeGen/GlobalISel/CMakeLists.txt
  lib/CodeGen/GlobalISel/GlobalISel.cpp
  lib/CodeGen/GlobalISel/InstructionSelectTestgen.cpp
  lib/CodeGen/GlobalISel/InstructionSelectorTestgen.cpp
  test/TableGen/GlobalISelEmitter.td
  utils/TableGen/GlobalISelEmitter.cpp
  utils/find_failing_instruction_select_rules.sh
  utils/update_instruction_select_testgen_tests.sh

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43962.147646.patch
Type: text/x-patch
Size: 77610 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180519/a145dc3c/attachment-0001.bin>


More information about the llvm-commits mailing list