[PATCH] D47088: Fix aliasing of launder.invariant.group
Jakub Kuderski via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 18 15:29:56 PDT 2018
kuhar added inline comments.
================
Comment at: llvm/lib/Analysis/BasicAliasAnalysis.cpp:135
static bool isEscapeSource(const Value *V) {
- if (auto CS = ImmutableCallSite(V)) {
- // launder_invariant_group captures its argument only by returning it,
- // so it might not be considered an escape by isNonEscapingLocalObject.
- // Note that adding similar special cases for intrinsics in CaptureTracking
- // requires handling them here too.
- if (CS.getIntrinsicID() == Intrinsic::launder_invariant_group)
- return false;
-
+ if (ImmutableCallSite(V))
return true;
----------------
Prazek wrote:
> kuhar wrote:
> > Why was the previous change reverted here?
> Because it is not needed now, check comment I left on line 1625
Makes sense, thanks
Repository:
rL LLVM
https://reviews.llvm.org/D47088
More information about the llvm-commits
mailing list