[PATCH] D47082: Fix build warning compiling TestPlugin on Windows and disable Passes plugin stuff on Windows since it fundamentally can't work

[Aaron Ballman via Phabricator via llvm-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.

In https://reviews.llvm.org/D47082#1105085, @rnk wrote:

> lgtm
>
> Thanks for resolving this!
>
> In https://reviews.llvm.org/D47082#1104998, @aaron.ballman wrote:
>
> > Have plugins ever worked on Windows when building with MSVC? I seem to recall them being disabled there specifically because we don't export and import interfaces from DLLs properly, but I could be remembering wrong.
>
>
> I don't think so. I think over the years people have done crazy stuff with dumpbin and LLVM_ENABLE_DYLIB (or whatever it's called) to make things kind of work, but it's never worked in any of the common build modes.


Okay, that's what I thought. Thank you for the confirmation -- patch LGTM as well.


https://reviews.llvm.org/D47082