[PATCH] D47082: Fix build warning compiling TestPlugin on Windows and disable Passes plugin stuff on Windows since it fundamentally can't work

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm

Thanks for resolving this!

In https://reviews.llvm.org/D47082#1104998, @aaron.ballman wrote:

> Have plugins ever worked on Windows when building with MSVC? I seem to recall them being disabled there specifically because we don't export and import interfaces from DLLs properly, but I could be remembering wrong.


I don't think so. I think over the years people have done crazy stuff with dumpbin and LLVM_ENABLE_DYLIB (or whatever it's called) to make things kind of work, but it's never worked in any of the common build modes.


https://reviews.llvm.org/D47082