[llvm] r332762 - Fixing build error introduced with r332759.

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Fri May 18 13:54:49 PDT 2018


There are also some warnings coming from this file

lib/DebugInfo/DWARF/DWARFUnit.cpp:325:40: warning: moving a temporary
object prevents copy elision [-Wpessimizing-move]
                           << toString(std::move(TableOrError.takeError()))
                                       ^
lib/DebugInfo/DWARF/DWARFUnit.cpp:325:40: note: remove std::move call here
                           << toString(std::move(TableOrError.takeError()))
                                       ^~~~~~~~~~                        ~
lib/DebugInfo/DWARF/DWARFUnit.cpp:380:38: warning: moving a temporary
object prevents copy elision [-Wpessimizing-move]
                         << toString(std::move(TableOrError.takeError()))
                                     ^
lib/DebugInfo/DWARF/DWARFUnit.cpp:380:38: note: remove std::move call here
                         << toString(std::move(TableOrError.takeError()))


~Craig


On Fri, May 18, 2018 at 1:38 PM Wolfgang Pieb via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: wolfgangp
> Date: Fri May 18 13:35:13 2018
> New Revision: 332762
>
> URL: http://llvm.org/viewvc/llvm-project?rev=332762&view=rev
> Log:
> Fixing build error introduced with r332759.
>
> Modified:
>     llvm/trunk/lib/DebugInfo/DWARF/DWARFUnit.cpp
>
> Modified: llvm/trunk/lib/DebugInfo/DWARF/DWARFUnit.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/DWARF/DWARFUnit.cpp?rev=332762&r1=332761&r2=332762&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/DebugInfo/DWARF/DWARFUnit.cpp (original)
> +++ llvm/trunk/lib/DebugInfo/DWARF/DWARFUnit.cpp Fri May 18 13:35:13 2018
> @@ -170,7 +170,7 @@ parseRngListTableHeader(DWARFDataExtract
>    }
>    llvm::DWARFDebugRnglistTable Table;
>    if (Error E = Table.extractHeaderAndOffsets(DA, &Offset))
> -    return E;
> +    return std::move(E);
>    return Table;
>  }
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180518/10a8d87c/attachment.html>


More information about the llvm-commits mailing list