[PATCH] D47040: MC: Change object writers to use endian::Writer. NFCI.
Peter Collingbourne via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 18 12:50:59 PDT 2018
pcc added inline comments.
================
Comment at: llvm/tools/dsymutil/MachOUtils.cpp:493
// transferSymbol).
- Writer.WriteZeros(1);
+ OutFile << '\0';
std::vector<DwarfStringPoolEntryRef> Strings = NewStrings.getEntries();
----------------
JDevlieghere wrote:
> Why not use `write_zeros` here too?
It seemed a little more straightforward to write the zero directly here.
https://reviews.llvm.org/D47040
More information about the llvm-commits
mailing list