[PATCH] D46857: [CMake] Detect the compiler runtime and standard library

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

This is causing warnings on Windows:

  -- Targeting WebAssembly
  clang-cl.exe: warning: unknown argument ignored in clang-cl: '--print-libgcc-file-name' [-Wunknown-argument]
  clang-cl.exe: error: no input files
  -- Compiler-RT supported architectures: x86_64

The fact that you are blindly passing `--print-libgcc-file-name` suggests that this code doesn't work with MSVC or any other compiler that has a non-GCC command line interface. Things might work, but I'd prefer it if it was relanded after proactively considering those cases, rather than patching a new pile of conditionals.

Looks like MSVC also warns:
http://lab.llvm.org:8011/builders/sanitizer-windows/builds/28806/steps/cmake/logs/stdio

  -- Targeting XCore
  DummyCXXFile.cxx
  Microsoft (R) Incremental Linker Version 14.00.24215.1
  Copyright (C) Microsoft Corporation.  All rights reserved.
  
  /out:DummyCXXFile.exe 
  DummyCXXFile.obj 
  Microsoft (R) C/C++ Optimizing Compiler Version 19.00.24215.1 for x86
  Copyright (C) Microsoft Corporation.  All rights reserved.
  
  cl : Command line warning D9002 : ignoring unknown option '--print-libgcc-file-name'
  cl : Command line error D8003 : missing source filename


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D46857