[PATCH] D43281: [AMDGPU] fixes for lds f32 builtins

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

I'm looking at how the address space mapping works for builtins, and I think what's there is just uselessly broken and needs to be fixed. It seems to be operating under the assumption that the address spaces the target defines are totally disjoint from the language address spaces



================
Comment at: lib/CodeGen/CGBuiltin.cpp:9909-9913
+        LangAS::opencl_local != E->getArg(0)
+                                    ->getType()
+                                    ->getPointeeType()
+                                    .getQualifiers()
+                                    .getAddressSpace() ||
----------------
Condition backwards


Repository:
  rC Clang

https://reviews.llvm.org/D43281