[PATCH] D47061: Revert recently added MIR test (causes buildbot failures).

Than McIntosh via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 18 10:39:25 PDT 2018


thanm added a comment.

In https://reviews.llvm.org/D47061#1104757, @dyung wrote:

> I don't think that removing only the test (especially when there is only 1 test) is correct. You should probably either fix the test, or revert the entire commit and resubmit for review once you have fixed the test.


Under most circumstances I think I would agree -- for example, if the change in question were introducing some new functionality whose behavior needed to be locked down.

In this case, the change is to avoid an assert in cases where you have an IR insanity (statically unreachable code) that is being created by an upstream pass--  there is no new behavior/functionality that needs checking, simply adding an additional guard to insure that the compiler doesn't crash when it sees this unexpected IR.

With that said, I'll go ahead and revert the whole thing.


Repository:
  rL LLVM

https://reviews.llvm.org/D47061





More information about the llvm-commits mailing list